You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue at: DOWNLOADS.computeIfAbsent(url) ignores the file parameter
To reproduce
Define a branch container both mc 1.20.3 and mc 1.20.4, using mojang mapping
Run the monument
Expected behavior
Both mc 1.20.3 and mc 1.20.4 have their mojang mapping.txt downloaded successfully
Actual behavior
Only the first download attempts to the mapping.txt will succeed
Reason: mc1.20.3 and mc1.20.4 use the same mapping.txt, causing the issue that the later download attempt will be skipped (due to the computeIfAbsent) call
More information on the same server_mappings and client_mappings:
monument/src/main/kotlin/de/skyrising/guardian/gen/files.kt
Lines 17 to 21 in a29e1a8
Issue at:
DOWNLOADS.computeIfAbsent(url)
ignores thefile
parameterTo reproduce
Expected behavior
Both mc 1.20.3 and mc 1.20.4 have their mojang mapping.txt downloaded successfully
Actual behavior
Only the first download attempts to the mapping.txt will succeed
Reason: mc1.20.3 and mc1.20.4 use the same mapping.txt, causing the issue that the later download attempt will be skipped (due to the
computeIfAbsent
) callMore information on the same server_mappings and client_mappings:
Example fix
The text was updated successfully, but these errors were encountered: