Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color obscures romaji / English script (Mac OS) #5

Open
hermesjpappas opened this issue May 10, 2022 · 2 comments
Open

Background color obscures romaji / English script (Mac OS) #5

hermesjpappas opened this issue May 10, 2022 · 2 comments

Comments

@hermesjpappas
Copy link

hermesjpappas commented May 10, 2022

Screenshot 2022-05-10 at 1 44 43 PM

Screenshot 2022-05-10 at 1 45 00 PM

This is true both in Alacritty where I have a custom configuration and also in the default Terminal app where no color modifications have been made. The only difference is it looks pitch black in the Terminal app.

The second image shows that the letters appear only when I drag over them with the mouse and select them.

The same thing happens with the English instructions in the interactive test.

Any ideas why this might be happening / how to fix it? 🤔 Thank you! 🙏

@MarcoFleres
Copy link

MarcoFleres commented May 19, 2022

If I read the code correctly, the text is supposed to be bold black, which renders it invisible.
You can change the color of the romaji by changing this line:

diff --git a/kanaquiz.py b/kanaquiz.py
index ab5de9e..528a07b 100755
--- a/kanaquiz.py
+++ b/kanaquiz.py
@@ -626,7 +626,7 @@ class CoreQuiz (object):
                 pos = item[4]
                 eng = item[2]
                 row[pos] = (7, item[0] + ' ' + item[1], 'c')
-                rom[pos] = (8, eng, 'c')
+                rom[pos] = (3, eng, 'c')
             rows.append(row)
             if romaji:
                 rows.append(rom)

The number 3 means yellow, and it follows ANSI Colors, but this implementation only supports until color 7.

@hermesjpappas
Copy link
Author

hermesjpappas commented May 20, 2022

If I read the code correctly, the text is supposed to be bold black, which renders it invisible. You can change the color of the romaji by changing this line:

diff --git a/kanaquiz.py b/kanaquiz.py
index ab5de9e..528a07b 100755
--- a/kanaquiz.py
+++ b/kanaquiz.py
@@ -626,7 +626,7 @@ class CoreQuiz (object):
                 pos = item[4]
                 eng = item[2]
                 row[pos] = (7, item[0] + ' ' + item[1], 'c')
-                rom[pos] = (8, eng, 'c')
+                rom[pos] = (3, eng, 'c')
             rows.append(row)
             if romaji:
                 rows.append(rom)

The number 3 means yellow, and it follows ANSI Colors, but this implementation only supports until color 7.

Thank you for this, I did a search in the code with vim and replaced it with 3 where it looked like it was referring to a color. I hope I didn't mess it up by replacing something that breaks in the code elsewhere but we'll see 😆

EDIT: If you also know of a way to remove the background color that'd be a great help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants