From d4897780e2afe1b7a760ed4aa9f0b55badd3d58e Mon Sep 17 00:00:00 2001 From: Adryan Alessandro Signor <17292004+AdryanSignor@users.noreply.github.com> Date: Thu, 5 Dec 2024 12:56:00 -0300 Subject: [PATCH] Fix code block creation without block ID (#41) --- src/Blocks/Virtual/VirtualBlock.php | 3 ++- tests/Functional/CreateTest.php | 3 +++ tests/Functional/assets/create/virtual-blocks.json | 7 +++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/Blocks/Virtual/VirtualBlock.php b/src/Blocks/Virtual/VirtualBlock.php index 790d088..2a3071f 100644 --- a/src/Blocks/Virtual/VirtualBlock.php +++ b/src/Blocks/Virtual/VirtualBlock.php @@ -26,7 +26,8 @@ public function getIterator(): Traversable { $blocks = parent::getIterator(); if ($this->blockId === null) { - return $blocks; + yield from $blocks; + return; } $index = 1; diff --git a/tests/Functional/CreateTest.php b/tests/Functional/CreateTest.php index 6c7f650..2288e1c 100644 --- a/tests/Functional/CreateTest.php +++ b/tests/Functional/CreateTest.php @@ -82,6 +82,9 @@ public function testCreatedVirtualComponentsMatchExpectedOutputJson(): void my code CODE, ), + Kit::codeBlock( + code: 'Code block without blockId' + ) ], ); diff --git a/tests/Functional/assets/create/virtual-blocks.json b/tests/Functional/assets/create/virtual-blocks.json index 4df0d5f..c726995 100644 --- a/tests/Functional/assets/create/virtual-blocks.json +++ b/tests/Functional/assets/create/virtual-blocks.json @@ -71,6 +71,13 @@ "type": "mrkdwn", "text": "```\nThis is\nmy code\n```" } + }, + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": "```\nCode block without blockId\n```" + } } ] }