Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Cache #6

Open
z64 opened this issue Jul 18, 2017 · 1 comment
Open

Cache #6

z64 opened this issue Jul 18, 2017 · 1 comment
Milestone

Comments

@z64
Copy link
Contributor

z64 commented Jul 18, 2017

Player objects tell us when the data in that request response may be stale via the @next_update attribute.

Considering the the API rate limit and how long a Player can go without being updated, we should provide a cache that will return cached Players that we know are still up-to-date, or make an API request on a cache miss or stale data (Time.now > player.next_update)

We may work other data objects into this cache if only for consistency, but at the least we should provide one specifically for Players, since it's probably the hottest path anyone will implement.

@z64
Copy link
Contributor Author

z64 commented Jul 20, 2017

Do we want to implement this for v1.0? It can wait if we want.

@z64 z64 added this to the v1.0.0 milestone Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant