-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show warning when using non-default target level #254
Comments
I think there are two issues at play here:
What are you suggesting specifically? If "Going higher (> -14 LUFS) than source LUFS is forcing dynamic processing" (per the comment thread) then there could be a warning that dynamic mode is being used. There is a warning already affecting the loudness range: ffmpeg-normalize/ffmpeg_normalize/_streams.py Lines 426 to 438 in 94c2c6a
Are you suggesting something akin to this? |
"show warning when using non-default target level" if cli_args.target_level < -23:
print(f"warning: using non-default target level {cli_args.target_level}. this can produce volume glitches. please verify the result.") |
I find this a bit too drastical. In your original issue you talked about increasing the target beyond the input loudness. I can imagine adding a warning for that. |
I did some checks on some files and it seems like the filter does not always revert to dynamic mode when the target is higher than the existing target. Instead, I'll parse the second pass loudnorm output and check if it shows that dynamic mode was used, compare that with the user's intent (i.e., if they wanted linear mode), and if there's a mismatch, print a warning. |
Fixed in v1.28.0, see #256 |
setting the target level too high can produce broken output
for example, increasing the target level from -23 to -14 can create ugly volume glitches
see also milahu/ffmpeg-loudnorm-volume-glitches-bug#1
in my case, the volume glitches were hidden in the middle of the album
so the defect is not obvious, and requires manual inspection of the result
ffmpeg-normalize/ffmpeg_normalize/__main__.py
Lines 140 to 155 in 94c2c6a
The text was updated successfully, but these errors were encountered: