-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new check
command
#23
Comments
Hey @k-aranke! Thank you for the interest in the project 😊 and sorry for only replying now. This type of check is definitely useful, I'm just wondering whether the coverage package should also measure the over-coverage. As the simplest form of implementing this, I could imagine logging a warning about such fields but I guess this is not very helpful when wanting to run this check in places where a machine needs decide whether there are no such columns (e.g. CI). Where did you have in mind that you would use this kind of information? |
A friendly ping @aranke -- would you happen to be able to provide a bit more background? |
Sure, this would be really useful in CI checks to catch typos in YAML. |
Thanks @aranke! I think we'd be happy to take a look at a PR if you'd be up for putting one together 🙂 |
@aranke if you are looking for a quick fix, with a different sort of an approach, maybe the |
Great work on this package; I tried building something similar earlier but will go with this package instead.
The command I want to add is
check
, which checks that all columns referenced in YAML are present in the table.Would this be something you'd be interested in adding to this package? If so, happy to contribute a PR.
The text was updated successfully, but these errors were encountered: