Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new check command #23

Open
aranke opened this issue Jan 29, 2022 · 5 comments
Open

Create a new check command #23

aranke opened this issue Jan 29, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@aranke
Copy link

aranke commented Jan 29, 2022

Great work on this package; I tried building something similar earlier but will go with this package instead.

The command I want to add is check, which checks that all columns referenced in YAML are present in the table.

Would this be something you'd be interested in adding to this package? If so, happy to contribute a PR.

@sweco
Copy link
Collaborator

sweco commented Feb 22, 2022

Hey @k-aranke! Thank you for the interest in the project 😊 and sorry for only replying now.

This type of check is definitely useful, I'm just wondering whether the coverage package should also measure the over-coverage. As the simplest form of implementing this, I could imagine logging a warning about such fields but I guess this is not very helpful when wanting to run this check in places where a machine needs decide whether there are no such columns (e.g. CI).

Where did you have in mind that you would use this kind of information?

@mrshu mrshu added the enhancement New feature or request label Nov 17, 2022
@mrshu
Copy link
Contributor

mrshu commented Nov 17, 2022

A friendly ping @aranke -- would you happen to be able to provide a bit more background?

@aranke
Copy link
Author

aranke commented Nov 21, 2022

Sure, this would be really useful in CI checks to catch typos in YAML.

@mrshu
Copy link
Contributor

mrshu commented Nov 21, 2022

Thanks @aranke!

I think we'd be happy to take a look at a PR if you'd be up for putting one together 🙂

@mrshu
Copy link
Contributor

mrshu commented Nov 28, 2022

@aranke if you are looking for a quick fix, with a different sort of an approach, maybe the dbt-meta-testing package might be of some help: https://hub.getdbt.com/tnightengale/dbt_meta_testing/latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants