Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the example-nextjs -> website #90

Open
jsjoeio opened this issue Oct 2, 2021 · 7 comments
Open

Rename the example-nextjs -> website #90

jsjoeio opened this issue Oct 2, 2021 · 7 comments

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 2, 2021

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

@Deep-Codes
Copy link
Contributor

Deep-Codes commented Oct 3, 2021

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

can with-nextjs be a good example?

have seen this pattern in bunch of repos

Screenshot 2021-10-03 at 10 02 43 AM

@shadab14meb346
Copy link
Contributor

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 4, 2021

@Deep-Codes Hmm...I mean this folder is specifically for the runwasm website. the "with-nextjs" is a common pattern when you explaining how to use X with Y,Z tools.

I don't think that would fit in this case.

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

I think we'll need to wait for @kennethcassel to chime in here!

@kennethcassel
Copy link
Contributor

@jsjoeio yeah we should rename it website!

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 27, 2021

@shadab14meb346 feel free to take this on (or if you don't want to do this, tell me and I will!)

@shadab14meb346
Copy link
Contributor

Hi @jsjoeio yeah you can go ahead and do it.
I see for me a lot of lint issues are coming some how.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 2, 2021

Not sure if/when I'll get to this so someone else can hop in if they want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants