Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID)) #365

Open
yoshimo opened this issue Sep 22, 2024 · 7 comments

Comments

@yoshimo
Copy link
Contributor

yoshimo commented Sep 22, 2024

4x bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))
[string "=[C]"]: in function `GetQuestTagInfo'
[string "@Grail/Grail.lua"]:7942: in function `GetQuestTagInfo'
[string "@Grail/Grail.lua"]:4056: in function `_AddWorldQuests'
[string "@Grail/Grail.lua"]:2319: in function `?'
[string "@Grail/Grail.lua"]:12641: in function `_Tooltip_OnEvent'
[string "@Grail/Grail.lua"]:13569: in function <Grail/Grail.lua:13569>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))"


still looking into it

@smaitch
Copy link
Owner

smaitch commented Sep 22, 2024

If you are running in the 11.0.5 PTR then I believe I have a fix for this.

diff --git a/Grail/Grail.lua b/Grail/Grail.lua
index 917e167..a7b5b41 100644
--- a/Grail/Grail.lua
+++ b/Grail/Grail.lua
@@ -4050,6 +4050,10 @@ end,
                                local tasks = C_TaskQuest.GetQuestsForPlayerByMapID(mapId)
                                if nil ~= tasks and 0 < #tasks then
                                        for k,v in ipairs(tasks) do
+                                               -- In 11.0.5 the questId is now questID so an adjustment is made here.
+                                               if nil == v.questId then
+                                                       v.questId = v.questID
+                                               end
                                                if self.GDE.debug then
                                                        local tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex = self:GetQuestTagInfo(v.questId)
                                                        if tagID and ((nil == self._LearnedWorldQuestProfessionMapping[tagID] and nil == self._LearnedWorldQuestTypeMapping[tagID]) or self.GDE.worldquestforcing) then

@yoshimo
Copy link
Contributor Author

yoshimo commented Sep 22, 2024

indeed i was.
Might not be needed once it goes life. Blizzards Interface errors too so i guess it is an oversight on their end.

@lucianahanan
Copy link

I'm on Live server and the error is still happening. Are they going to fix the code any time soon?

@yoshimo
Copy link
Contributor Author

yoshimo commented Oct 30, 2024

until @smaitch has released a new version you can add the changes of #365 (comment) yourself.
They are part of #363 too.

@draGonFX76
Copy link

Hi, i got the error aswell, what are we supposed to do with this code above?

@yoshimo
Copy link
Contributor Author

yoshimo commented Dec 9, 2024

Hi, i got the error aswell, what are we supposed to do with this code above?

You could open the file Grail.lua , find the Lines around GetQuestsForPlayerByMapID and add the 3 lines that start with + (without that sign itself) so the block is extended.

The simpler solution is downloading https://github.com/smaitch/Grail/archive/refs/heads/master.zip and putting the Grail-Folders from within that archive in your Interface\Addons folder and overwrite the existing ones.
That way you will get the most recent quest data as well.

@draGonFX76
Copy link

Hi

Thanks for that, this solved it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants