Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] check duplicate keys #1269

Closed
fugerit79 opened this issue Dec 15, 2024 · 0 comments · Fixed by #1270
Closed

[enhancement] check duplicate keys #1269

fugerit79 opened this issue Dec 15, 2024 · 0 comments · Fixed by #1270

Comments

@fugerit79
Copy link
Contributor

fugerit79 commented Dec 15, 2024 •
edited
Loading

EDIT(2024-12-16): After advices from PR #1270, the goal has been limited to just warn for duplicate keys on properties config source.

Sometimes happens that the same config name is found multiple time in the same config source.

For instance :

quarkus.bannner.enabled=false
quarkus.bannner.enabled=true

Or

quarkus:
  banner:
    enabled: false
  banner:
    enabled: true

In our quarkus projects (whose configuration is based on smallrye-config) this is just silently ignored.

I know that IDE helps avoiding it and developers should be disciplined when writing configuration, but in our large teams sometimes this happened.

But for a Developer Joy approach, it could be helpful to have an Out Of The Box solution.

For instance we could enable duplicate keys check with a system property like ?

smallrye.config.forbid-duplicate-keys

Note : main goal is to use this feature to che configurations at dev or in the CI
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 15, 2024
@fugerit79
check duplicate keys (properties) smallrye#1269
55fc1fb 
If property :
smallrye.config.forbidDuplicateKeys
is set to true

A ConfigValidationException will be raised if duplicate keys are found in the same config source.

smallrye#1269
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 15, 2024
@fugerit79
check duplicate keys (yaml) smallrye#1269
5ad0419 
If property :
smallrye.config.forbidDuplicateKeys
is set to true

A ConfigValidationException will be raised if duplicate keys are found in the same config source.

smallrye#1269
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 15, 2024
@fugerit79
check duplicate keys (documentation) smallrye#1269
51b4625 
If property :
smallrye.config.forbidDuplicateKeys
is set to true

A ConfigValidationException will be raised if duplicate keys are found in the same config source.

smallrye#1269
@fugerit79 fugerit79 mentioned this issue Dec 15, 2024
Merged
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 15, 2024
@fugerit79
check duplicate keys (rename property) smallrye#1269
c9ccf3c 
If property :
smallrye.config.forbid-duplicate-keys
is set to true

A ConfigValidationException will be raised if duplicate keys are found in the same config source.

smallrye#1269
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 16, 2024
@fugerit79
check duplicate keys (properties) smallrye#1269
1285338 
Only for properties config source : duplicate keys found in te same config source will be logged as warning.
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 19, 2024
@fugerit79
check duplicate values (added log method) smallrye#1269
c562fb9 
Added a log method in ConfigLogging to handle duplicate values.
radcortez pushed a commit that referenced this issue Dec 19, 2024
@fugerit79 @radcortez
check duplicate values (added log method) #1269
d9c6de2 
Added a log method in ConfigLogging to handle duplicate values.
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 19, 2024
@fugerit79
check duplicate values (code formatting) smallrye#1269
e50ff95
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 19, 2024
@fugerit79
check duplicate keys (properties) smallrye#1269
cd70fbb 
Only for properties config source : duplicate keys found in te same config source will be logged as warning.
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 19, 2024
@fugerit79
check duplicate values (added log method) smallrye#1269
1cf192a 
Added a log method in ConfigLogging to handle duplicate values.
fugerit79 added a commit to fugerit-org/smallrye-config that referenced this issue Dec 19, 2024
@fugerit79
check duplicate values (code formatting) smallrye#1269
37634ef
radcortez pushed a commit that referenced this issue Dec 20, 2024
@fugerit79
check duplicate keys (#1270)
7d66a3a 
* check duplicate keys (properties) #1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check duplicate keys fugerit-org/smallrye-config
1 participant
@fugerit79