Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent enablement of Federation #1689

Open
t1 opened this issue Jan 8, 2023 · 4 comments
Open

Inconsistent enablement of Federation #1689

t1 opened this issue Jan 8, 2023 · 4 comments
Assignees
Labels
bug Something isn't working Server This issue applies to the Server side

Comments

@t1
Copy link
Collaborator

t1 commented Jan 8, 2023

In 1.9.1, enabling Federation is not automatic any more and is only possible with a system property

@t1 t1 added bug Something isn't working Server This issue applies to the Server side labels Jan 8, 2023
@t1 t1 self-assigned this Jan 8, 2023
t1 added a commit to t1/smallrye-graphql that referenced this issue Jan 8, 2023
t1 added a commit to t1/smallrye-graphql that referenced this issue Jan 8, 2023
@jmartisk
Copy link
Member

jmartisk commented Jan 9, 2023

No, it's automatic, at least it will be when quarkus updates to SmallRye GraphQL 1.9.1/2.0.1 via this PR: https://github.com/quarkusio/quarkus/pull/30227/files (see SmallRyeGraphQLProcessor#activateFederation)

For WildFly, I am going to do something similar.

@jmartisk
Copy link
Member

jmartisk commented Jan 9, 2023

I want to make the automatic enablement handled by the runtime, not directly in SmallRye, because different runtimes have different configuration mechanisms - for example Quarkus has its own configuration property for enabling federation (quarkus.smallrye-graphql.federation.enabled), and I want Quarkus to decide based on THAT property, not based only on smallrye.graphql.federation.enabled, so the plan is that Quarkus will set the value of smallrye.graphql.federation.enabled by itself, and then the SchemaBuilder will be controlled by that value.

@t1
Copy link
Collaborator Author

t1 commented Jan 9, 2023

Okay, I see... but wouldn't it make more sense to implement it once? Have you seen #1690

@jmartisk
Copy link
Member

I've commented on the PR, I think it might make sense, but it would need some changes, let's move the discussion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Server This issue applies to the Server side
Projects
None yet
Development

No branches or pull requests

2 participants