Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using PostCreator for importing posts #21

Open
sman591 opened this issue Mar 28, 2016 · 2 comments
Open

Switch to using PostCreator for importing posts #21

sman591 opened this issue Mar 28, 2016 · 2 comments
Labels
enhancement

Comments

@sman591
Copy link
Owner

sman591 commented Mar 28, 2016

Discourse has a PostCreator that handles a bunch of extra logic this bridge doesn't consider, and consolidates a lot of logic (such as bumping posts, #20). We should switch to using that instead of doing raw Post.create calls.

A simple example of use: https://github.com/discourse/try-bot/blob/master/plugin.rb
sman591 added a commit that referenced this issue Mar 28, 2016
@sman591
Fixed topic bumping with imported NNTP posts
fa012f6 
Resolves #20

A better solution will be coming in #21
@sman591
Copy link
Owner Author

sman591 commented Mar 31, 2016

Also: https://github.com/discourse/discourse/blob/master/script/import_scripts/base.rb#L466

@sman591
Copy link
Owner Author

sman591 commented Apr 5, 2016

This will likely cause a feedback loop because of on(:post_created), which will need to be avoided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sman591