CCIP-4408: E2E test for LBTC #1563
Open
+3,416
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TokenPool contract constructor works when you set the decimal arg to 18 instead of 6
b-gopalswami
force-pushed
the
ccip-4408
branch
from
89faf57 to
4081a34
Compare
b-gopalswami
requested review from
a team,
makramkd,
elatoskinas and
RayXpub
as code owners
rstout
reviewed
Dec 9, 2024
| @@ -989,6 +1004,32 @@ func (ccipModule *CCIPCommon) DeployContracts( | |||
| } | |||
|
|
|||
| ccipModule.BridgeTokenPools = append(ccipModule.BridgeTokenPools, usdcPool) | |||
| } else if ccipModule.IsLBTCDeployment() && i == 0 { | |||
| ccipModule.Logger.Warn().Msg("Right before lbtcPool") | |||
There was a problem hiding this comment.
We can remove these debug comments
rstout
reviewed
Dec 9, 2024
| } else if ccipModule.IsLBTCDeployment() && i == 0 { | ||
| ccipModule.Logger.Warn().Msg("Right before lbtcPool") | ||
| rmnContract := *ccipModule.RMNContract | ||
| ccipModule.Logger.Warn().Msg(fmt.Sprintf("token addr: %v, RMN contract %v, router addr: %v", token.Address(), rmnContract, ccipModule.Router.Instance.Address())) |
rstout
approved these changes
Dec 9, 2024
rstout
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution