From a0128662e38fede8a45dedce5b6d47e899114e0b Mon Sep 17 00:00:00 2001 From: Dylan Tinianov Date: Fri, 10 Jan 2025 16:49:19 -0500 Subject: [PATCH] Export RegisterSub --- multinode/adaptor.go | 8 ++++---- multinode/adaptor_test.go | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/multinode/adaptor.go b/multinode/adaptor.go index 7b7a1a2..a87f759 100644 --- a/multinode/adaptor.go +++ b/multinode/adaptor.go @@ -64,8 +64,8 @@ func (m *Adapter[RPC, HEAD]) LenSubs() int { return len(m.subs) } -// registerSub adds the sub to the rpcMultiNodeAdapter list -func (m *Adapter[RPC, HEAD]) registerSub(sub *ManagedSubscription, stopInFLightCh chan struct{}) error { +// RegisterSub adds the sub to the Adaptor list +func (m *Adapter[RPC, HEAD]) RegisterSub(sub *ManagedSubscription, stopInFLightCh chan struct{}) error { // ensure that the `sub` belongs to current life cycle of the `rpcMultiNodeAdapter` and it should not be killed due to // previous `DisconnectAll` call. select { @@ -146,7 +146,7 @@ func (m *Adapter[RPC, HEAD]) SubscribeToHeads(ctx context.Context) (<-chan HEAD, onUnsubscribe: m.removeSub, } - err := m.registerSub(sub, chStopInFlight) + err := m.RegisterSub(sub, chStopInFlight) if err != nil { sub.Unsubscribe() return nil, nil, err @@ -179,7 +179,7 @@ func (m *Adapter[RPC, HEAD]) SubscribeToFinalizedHeads(ctx context.Context) (<-c onUnsubscribe: m.removeSub, } - err := m.registerSub(sub, chStopInFlight) + err := m.RegisterSub(sub, chStopInFlight) if err != nil { sub.Unsubscribe() return nil, nil, err diff --git a/multinode/adaptor_test.go b/multinode/adaptor_test.go index f9fdbe7..c4c6b3a 100644 --- a/multinode/adaptor_test.go +++ b/multinode/adaptor_test.go @@ -131,14 +131,14 @@ func (s *mockSub) Err() <-chan error { } func TestMultiNodeClient_RegisterSubs(t *testing.T) { - t.Run("registerSub", func(t *testing.T) { + t.Run("RegisterSub", func(t *testing.T) { c := newTestClient(t) mockSub := newMockSub() sub := &ManagedSubscription{ Subscription: mockSub, onUnsubscribe: c.removeSub, } - err := c.registerSub(sub, make(chan struct{})) + err := c.RegisterSub(sub, make(chan struct{})) require.NoError(t, err) require.Equal(t, 1, c.LenSubs()) c.UnsubscribeAllExcept() @@ -153,7 +153,7 @@ func TestMultiNodeClient_RegisterSubs(t *testing.T) { Subscription: mockSub, onUnsubscribe: c.removeSub, } - err := c.registerSub(sub, chStopInFlight) + err := c.RegisterSub(sub, chStopInFlight) require.Error(t, err) require.True(t, mockSub.unsubscribed) }) @@ -171,9 +171,9 @@ func TestMultiNodeClient_RegisterSubs(t *testing.T) { Subscription: mockSub2, onUnsubscribe: c.removeSub, } - err := c.registerSub(sub1, chStopInFlight) + err := c.RegisterSub(sub1, chStopInFlight) require.NoError(t, err) - err = c.registerSub(sub2, chStopInFlight) + err = c.RegisterSub(sub2, chStopInFlight) require.NoError(t, err) require.Equal(t, 2, c.LenSubs())