Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Updates - Mon Sep 9 00:14:11 UTC 2024 #846

Closed
github-actions bot opened this issue Sep 9, 2024 · 0 comments
Closed

Upstream Updates - Mon Sep 9 00:14:11 UTC 2024 #846

github-actions bot opened this issue Sep 9, 2024 · 0 comments
Assignees
Labels
AUTO: Upstream Updates Auto-generated from tracking upstream repos

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

SIMD

Opened

Closed

Agave Wiki

693e82d7968789055f768d99e9b24e699685c396^..bd88e80780a87e8703e79d0da2ffc81d74fcffbe

diff --git a/Backport-Guidelines.md b/Backport-Guidelines.md
new file mode 100644
index 0000000..d180c81
--- /dev/null
+++ b/Backport-Guidelines.md
@@ -0,0 +1,22 @@
+## Agave Backport Review Guidelines
+
+Code changes to Agave are normally made to the master branch. Bug fixes can be backported directly to the beta and stable branches if the benefit of doing so outweighs the risk. Backports must be approved by a member of the [Backport Reviewers group](https://github.com/orgs/anza-xyz/teams/backport-reviewers).
+
+### Backports must:
+* Fix a bug, or facilitate debugging of a known / suspected bug
+* Be the smallest / simplest solution that can reasonably address the bug. Often a bug fix involves refactoring or code cleanup. In those cases the work should be done in at least 2 PRs:
+  * The smallest / simplest solution to the bug, which is eligible to be backported.
+  * The rest of the changes, which should not be backported.
+  * Ask the Backport Reviewers for feedback on your `master` PR if you're unsure about this criteria.
+* Be merged to all newer branches first (master before beta, beta before stable).
+* Have been run on a node on a suitable public cluster unless inappropriate to do so.
+
+### Backports to stable must:
+* Be audited before being merged, if they modify a portion of the code that we typically audit
+
+### Criteria for reviewing backports:
+1) The severity of the bug being fixed
+1) How much complexity the change introduces
+1) How thoroughly the change has been tested
+1) If a new bug is introduced, how severe could it be, and how long until it will be recommended for mainnet-beta. Commits to the stable branch ship to mainnet-beta weekly, leaving very little opportunity to discover a newly introduced bug. Commits to the beta branch ship to mainnet-beta at the end of the stabilization cycle. Backports to beta late in the stabilization cycle carry more risk and should be reviewed more stringently.
+​​​
 No newline at end of file
diff --git a/_Sidebar.md b/_Sidebar.md
index f20904a..890f363 100644
--- a/_Sidebar.md
+++ b/_Sidebar.md
@@ -9,6 +9,8 @@
   * [General Debugging](General-Debugging)
   * [Debugging Consensus Failures](Debugging-Consensus-Failures)
   * [Incremental Snapshots](Incremental-Snapshots)
+* **Policy**
+  * [Backport Guidelines](Backport-Guidelines)
 * **Schedule**
   * [v1.16 Release Schedule](v1.16-Release-Schedule)
   * [v1.17 Release Schedule](v1.17-Release-Schedule)
@@ -17,7 +19,7 @@
   * [Agave Transition](Agave-Transition)
 * **Migration**
   * [Agave v2.0 Migration](Agave-v2.0-Transition-Guide)
-* **Testnet**
+* **Restart Instructions**
   * [2024-01-02 Testnet Restart](2024‐01‐02-Testnet-Rollback-and-Restart)
   * [2024-08-26 Testnet Restart](2024-08-26-Testnet-Restart)
   
 No newline at end of file 
@github-actions github-actions bot added the AUTO: Upstream Updates Auto-generated from tracking upstream repos label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTO: Upstream Updates Auto-generated from tracking upstream repos
Projects
None yet
Development

No branches or pull requests

1 participant