-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Flakeguard reports: Split commands and use data and presentation layers #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcl
force-pushed
the
refactor-flakeguard-report
branch
from
December 5, 2024 16:27
9760bcf
to
d9043b4
Compare
kalverra
approved these changes
Dec 6, 2024
lukaszcl
force-pushed
the
refactor-flakeguard-report
branch
from
December 9, 2024 11:52
caaac6d
to
6653333
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR in Core repo: smartcontractkit/chainlink#15541
Last Flakeguard Nightly that uses this version: https://github.com/smartcontractkit/chainlink/actions/runs/12204545695
1. Unified Command
Single
report
Commandaggregate-results
andgenerate-reports
commands.--format
flag.Rationale
2. Layer Enhancements
Refactored Architecture:
Benefits:
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce several enhancements and fixes across multiple files in the Flakeguard tool, focusing on improving test results aggregation, error handling, and reporting. Notably, it refactors
aggregate_results.go
to use a more robust file system handling, improves error reporting, and adds functionality to generate a summary of all tests. Adjustments in other files likecheck_test_owners.go
,generate_report.go
, andrun.go
complement these enhancements by refining test ownership checks, report generation, and test execution processes. The introduction of new filesdata.go
,io.go
, andpresentation.go
modularizes code for better maintenance and clarity, while the removal ofreports.go
suggests a restructuring of how test results and reports are managed.What
reports.OSFileSystem
for file operations.reports.go
functionalities have likely been moved or restructured.