Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cadvisor #1449

Merged
merged 3 commits into from
Dec 9, 2024
Merged

cadvisor #1449

merged 3 commits into from
Dec 9, 2024

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Dec 9, 2024

  • Add cadvisor + dashboard
image

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce cadvisor support to monitor resources of test containers, enhancing the observability framework. Updates to Prometheus configurations, a new cadvisor dashboard for Grafana, and adjustments in dashboard provisioning reflect efforts to improve resource monitoring and management.

What

  • book/src/framework/observability/metrics.md
    • Added Docker Resources section with details on using cadvisor for monitoring container resources.
  • framework/.changeset/v0.3.5.md
    • Documented the addition of cadvisor support and dashboard.
  • framework/cmd/observability/compose/conf/prometheus.yml
    • Added a new job configuration for cadvisor with a scrape interval of 10s.
  • framework/cmd/observability/compose/conf/provisioning/dashboards/cadvisor/cadvisor.json
    • Introduced a new cadvisor dashboard configuration for Grafana.
  • framework/cmd/observability/compose/conf/provisioning/dashboards/dashboards.yaml
    • Changed provider name from 'WASP' to 'Local' and updated the folder name to 'Dashboards'.
  • framework/cmd/observability/compose/docker-compose.yaml
    • Added cadvisor service configuration with necessary volume mounts and network ports.
  • framework/examples/myproject/go.mod and framework/examples/myproject/go.sum
    • Updated dependencies reflecting new imports necessary for cadvisor integration and other enhancements.

@skudasov skudasov requested review from sebawo and a team as code owners December 9, 2024 10:14
@skudasov skudasov requested a review from Tofel December 9, 2024 10:15
@skudasov skudasov requested a review from lukaszcl December 9, 2024 10:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@skudasov skudasov merged commit 5f9debf into main Dec 9, 2024
48 of 49 checks passed
@skudasov skudasov deleted the cadvisor branch December 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants