Add metadata to Flakeguard report #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kalverra
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce metadata fields related to the repository and commit SHAs into the test report and aggregate results command. This enriches the test reports with crucial versioning and source information, making it easier to trace test results back to specific changes in the codebase.
What
tools/flakeguard/cmd/aggregate_results.gorepo-url,head-sha,base-sha, andgithub-workflow-name. This allows users to specify repository details and commit SHAs when aggregating test results.HeadSHA,BaseSHA,RepoURL,GitHubWorkflowName) in the aggregated test report. This ensures that the report contains detailed context about the source of the test results.tools/flakeguard/reports/data.goTestReportstructure to includeHeadSHA,BaseSHA,RepoURL, andGitHubWorkflowNamefields alongside existing test report details. This update aligns the data structure with the new information being aggregated in the command changes.