Fix url and add node container internal ip #1477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes made to
clnode.go
andjd.go
improve network configuration and address formatting. Inclnode.go
, anInternalIP
field is added to provide direct access to the container's internal IP, enhancing connectivity options within the network. Injd.go
, the URL formatting for GRPC and WebSocket RPC URLs is corrected by removing the redundanthttp://
scheme, aligning the URLs with typical GRPC and WebSocket addressing conventions.What
framework/components/clnode/clnode.go
InternalIP
field toNodeOut
struct to include the internal IP address of the Chainlink node container.newNode
function. This change facilitates direct internal access to the node, useful in networked container environments.framework/components/jd/jd.go
Output
struct. Removedhttp://
from GRPC and WebSocket RPC URLs to correct the URL scheme. This change ensures that the URLs are correctly formatted for their respective protocols, with GRPC typically not usinghttp://
and WebSocket URLs specified asws://
orwss://
for secure connections.