Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url and add node container internal ip #1477

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix url and add node container internal ip #1477

merged 1 commit into from
Dec 12, 2024

Conversation

b-gopalswami
Copy link
Contributor

@b-gopalswami b-gopalswami commented Dec 12, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes made to clnode.go and jd.go improve network configuration and address formatting. In clnode.go, an InternalIP field is added to provide direct access to the container's internal IP, enhancing connectivity options within the network. In jd.go, the URL formatting for GRPC and WebSocket RPC URLs is corrected by removing the redundant http:// scheme, aligning the URLs with typical GRPC and WebSocket addressing conventions.

What

  • framework/components/clnode/clnode.go
    • Added InternalIP field to NodeOut struct to include the internal IP address of the Chainlink node container.
    • Added logic to retrieve and set the container's internal IP address in the newNode function. This change facilitates direct internal access to the node, useful in networked container environments.
  • framework/components/jd/jd.go
    • Modified URL formatting in Output struct. Removed http:// from GRPC and WebSocket RPC URLs to correct the URL scheme. This change ensures that the URLs are correctly formatted for their respective protocols, with GRPC typically not using http:// and WebSocket URLs specified as ws:// or wss:// for secure connections.

@b-gopalswami b-gopalswami requested review from sebawo and a team as code owners December 12, 2024 15:09
@cl-sonarqube-production
Copy link

@skudasov skudasov merged commit 8f36945 into main Dec 12, 2024
48 of 49 checks passed
@skudasov skudasov deleted the fix-jd-url branch December 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants