Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… #15121

fernandezlautaro · 2024-11-05T14:55:27Z

… needed error mappings

Adding config chains for testnet (all 5) and mainnet (for 3).

B^2/Bsquared: testnet + mainnet
Berachain: testnet
BoB: testnet + mainnet
Unichain: testnet
Worldchain: testnet + mainnet

Related PR: smartcontractkit/ccip#1521

Requires

Supports

… needed error mappings

github-actions · 2024-11-05T15:09:39Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml

core/chains/evm/client/errors.go

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml

core/chains/evm/config/toml/defaults/Berachain_Testnet.toml

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml

… for Unichain as it has discrepancies with the data obtained from the compat tests and current testnet values

github-actions · 2024-11-06T15:29:53Z

Flaky Test Detector for `./go.mod` project has failed ❌

Ran new or updated tests between develop and aadad4f (batch1_2024).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 204 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                      TestName                                                                                                          PassRatio  RunCount   Skipped
---------                                                        ---------                                                                                                         ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/chains/evm/client  TestRPCClient_SubscribeToHeads/Closed_rpc_client_should_remove_existing_SubscribeToHeads_subscription_with_WS#01  80%        5          false
github.com/smartcontractkit/chainlink/v2/core/chains/evm/client  TestRPCClient_SubscribeToHeads                                                                                    80%        5          false

github-actions · 2024-11-06T17:55:27Z

Flaky Test Detector for `./go.mod` project has failed ❌

Ran new or updated tests between develop and aadad4f (batch1_2024).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 408 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                      TestName                                                                                                          PassRatio  RunCount   Skipped
---------                                                        ---------                                                                                                         ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/chains/evm/client  TestRPCClient_SubscribeToHeads/Closed_rpc_client_should_remove_existing_SubscribeToHeads_subscription_with_WS#01  80%        5          false
github.com/smartcontractkit/chainlink/v2/core/chains/evm/client  TestRPCClient_SubscribeToHeads                                                                                    80%        5          false

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml

core/chains/evm/config/toml/defaults/BOB_Testnet.toml

…rgs at depth 1

mohamed-mehany

Changes looks good.
Based on a quick look, it seems that the CI failures are not related / flakey.

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and…

e3ca2df

… needed error mappings

fernandezlautaro requested review from a team as code owners November 5, 2024 14:55

fernandezlautaro requested review from simsonraj and mohamed-mehany November 5, 2024 14:55

fernandezlautaro and others added 2 commits November 5, 2024 12:29

bumping NoNewFinalizedHeadsThreshold to some chains

fc7c81f

Add oracle config

273ffd6

friedemannf reviewed Nov 5, 2024

View reviewed changes

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml Outdated Show resolved Hide resolved

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml Outdated Show resolved Hide resolved

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml Show resolved Hide resolved

simsonraj reviewed Nov 6, 2024

View reviewed changes

fernandezlautaro added 3 commits November 6, 2024 11:06

adding changes from Friedemann and Simson

13f606e

adding new 'math'/algorithm to calculate NoNewFinalizedHeadsThreshold…

e45bc20

… for Unichain as it has discrepancies with the data obtained from the compat tests and current testnet values

adding changeset

aadad4f

fernandezlautaro requested a review from a team as a code owner November 6, 2024 15:24

fernandezlautaro requested a review from pavel-raykov November 6, 2024 15:24

dhaidashenko previously approved these changes Nov 6, 2024

View reviewed changes

friedemannf previously approved these changes Nov 6, 2024

View reviewed changes

removing error mappings to berachain

24f8532

fernandezlautaro dismissed stale reviews from friedemannf and dhaidashenko via 24f8532 November 6, 2024 18:06

fernandezlautaro mentioned this pull request Nov 6, 2024

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… smartcontractkit/ccip#1521

Merged

friedemannf previously approved these changes Nov 6, 2024

View reviewed changes

changeset missing tag

773fc93

fernandezlautaro dismissed friedemannf’s stale review via 773fc93 November 7, 2024 15:52

pavel-raykov reviewed Nov 7, 2024

View reviewed changes

core/chains/evm/config/toml/defaults/BOB_Mainnet.toml Outdated Show resolved Hide resolved

dead link, update

3adb84f

pavel-raykov previously approved these changes Nov 7, 2024

View reviewed changes

core/chains/evm/config/toml/defaults/BOB_Testnet.toml Outdated Show resolved Hide resolved

adding config docs

dc0b95d

changing berachain to not honor the finality tag due to possible re-o…

fe952c0

…rgs at depth 1

fernandezlautaro dismissed stale reviews from dhaidashenko, amit-momin, simsonraj, and mohamed-mehany via fe952c0 November 8, 2024 01:43

forgot make config-docs command

845a5ca

pavel-raykov previously approved these changes Nov 8, 2024

View reviewed changes

SHIP-3990: improving working configs

0b94340

fernandezlautaro dismissed pavel-raykov’s stale review via 0b94340 November 12, 2024 16:51

pavel-raykov previously approved these changes Nov 12, 2024

View reviewed changes

error in logPollInterval

b28bfb4

fernandezlautaro dismissed pavel-raykov’s stale review via b28bfb4 November 12, 2024 21:05

pavel-raykov previously approved these changes Nov 13, 2024

View reviewed changes

forgot make config-docs

54ad9bf

fernandezlautaro dismissed pavel-raykov’s stale review via 54ad9bf November 14, 2024 17:29

mohamed-mehany previously approved these changes Nov 19, 2024

View reviewed changes

BOB fixing finality depth in mainnet

d3c7225

fernandezlautaro dismissed mohamed-mehany’s stale review via d3c7225 November 20, 2024 19:26

mohamed-mehany previously approved these changes Nov 21, 2024

View reviewed changes

fernandezlautaro added 2 commits November 21, 2024 10:06

Merge remote-tracking branch 'origin/develop' into batch1_2024

ca2e53f

running make config-docs

77991e1

fernandezlautaro dismissed mohamed-mehany’s stale review via 77991e1 November 21, 2024 13:10

jmank88 approved these changes Nov 21, 2024

View reviewed changes

mohamed-mehany approved these changes Nov 21, 2024

View reviewed changes

simsonraj added this pull request to the merge queue Nov 21, 2024

Merged via the queue into develop with commit 5d22ba8 Nov 21, 2024
146 checks passed

simsonraj deleted the batch1_2024 branch November 21, 2024 16:42

This was referenced Nov 21, 2024

[DO NOT MERGE] Changeset Release Preview - v2.19.0 #13148

Draft

[DO NOT MERGE] Changeset Release Preview - v2.19.0 galactic-beyond/chainlink#1

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… #15121

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… #15121

fernandezlautaro commented Nov 5, 2024

github-actions bot commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

mohamed-mehany left a comment

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… #15121

Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and… #15121

Conversation

fernandezlautaro commented Nov 5, 2024

Requires

Supports

github-actions bot commented Nov 5, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Nov 6, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 6, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Failed Tests

mohamed-mehany left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2024 •

edited

Loading

Flaky Test Detector for `./go.mod` project has failed ❌

Flaky Test Detector for `./go.mod` project has failed ❌