Refactor chain ID logic in plugin to be chain agnostic #15213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
huangzhen1997
requested review from
EasterTheBunny,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
prashantkumar1982
silaslenihan
previously approved these changes
Nov 14, 2024
jmank88
previously approved these changes
Nov 14, 2024
| @@ -119,13 +118,17 @@ func (i *pluginOracleCreator) Create(ctx context.Context, donID uint32, config c | |||
| pluginType := cctypes.PluginType(config.Config.PluginType) | |||
|
|
|||
| // Assuming that the chain selector is referring to an evm chain for now. | |||
There was a problem hiding this comment.
nit: Remove this comment
huangzhen1997
dismissed stale reviews from jmank88 and silaslenihan
via
e084bd0
huangzhen1997
requested review from
prashantkumar1982,
silaslenihan and
jmank88
silaslenihan
approved these changes
Nov 14, 2024
prashantkumar1982
approved these changes
Nov 14, 2024
winder
approved these changes
Nov 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Refactor chain ID logic in plugin to be chain agnostic * fix script error * update mod * update dependency * revert changes on mod * remove old comment
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prashantkumar1982
deleted the
NONEVM-826/abstract-the-chainID-chainFamily-fetching-logic-to-be-chain-agnostic
branch
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/NONEVM-826
Abstract the chainID/chainFamily fetching logic to be chain agnostic in plugin.go