Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/client: convert MultiNode to use *services.Engine #15216

Merged
merged 1 commit into from
Nov 18, 2024
Merged

common/client: convert MultiNode to use *services.Engine #15216

merged 1 commit into from
Nov 18, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 12, 2024 •
edited
Loading

@jmank88 jmank88 requested review from a team as code owners November 12, 2024 22:33
jmank88
jmank88 commented Nov 12, 2024
View reviewed changes
common/client/multi_node.go Outdated Show resolved Hide resolved
@jmank88 jmank88 marked this pull request as draft November 12, 2024 22:36
@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch from 4976276 to 46f01c9 Compare November 12, 2024 22:43
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch from 46f01c9 to 5c8e93e Compare November 12, 2024 23:10
@jmank88 jmank88 mentioned this pull request Nov 13, 2024
Merged
@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch 2 times, most recently from a6032b5 to 449e6c9 Compare November 13, 2024 13:58
@jmank88 jmank88 marked this pull request as ready for review November 13, 2024 15:44
@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch 2 times, most recently from f129128 to 63e8de5 Compare November 14, 2024 15:43
krehermann
krehermann previously approved these changes Nov 14, 2024
View reviewed changes
samsondav
samsondav previously approved these changes Nov 14, 2024
View reviewed changes
DylanTinianov
DylanTinianov previously approved these changes Nov 14, 2024
View reviewed changes
vyzaldysanchez
vyzaldysanchez previously approved these changes Nov 14, 2024
View reviewed changes
EasterTheBunny
EasterTheBunny previously approved these changes Nov 14, 2024
View reviewed changes
@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch from 63e8de5 to c59554e Compare November 14, 2024 21:54
@jmank88 jmank88 enabled auto-merge November 14, 2024 21:54
@jmank88
Copy link
Contributor Author

jmank88 commented Nov 14, 2024

Rebased for conflicts

@jmank88 jmank88 force-pushed the BCF-3337-service-engine branch from c59554e to 5f4c1e6 Compare November 14, 2024 21:59
@jmank88 jmank88 added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into develop with commit 50fc67f Nov 18, 2024
140 of 143 checks passed
@jmank88 jmank88 deleted the BCF-3337-service-engine branch November 18, 2024 18:18
cedric-cordenier pushed a commit that referenced this pull request Nov 20, 2024
@jmank88 @cedric-cordenier
common/client: convert MultiNode to use *services.Engine (#15216)
1cede98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@samsondav samsondav samsondav approved these changes

@dimriou dimriou Awaiting requested review from dimriou

@krehermann krehermann Awaiting requested review from krehermann

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmank88 @samsondav @EasterTheBunny @vyzaldysanchez @krehermann @DylanTinianov @ilija42