integration-tests/smoke: move ccip msging test #15217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
requested review from
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
dimkouv
approved these changes
Nov 13, 2024
| - PR E2E Core Tests | ||
| - Merge Queue E2E Core Tests | ||
| - Nightly E2E Tests | ||
| test_cmd: cd integration-tests/ && go test smoke/ccip_messaging_test.go -timeout 12m -test.parallel=1 -count=1 -json |
There was a problem hiding this comment.
nit:
--- cd integration-tests/ && go test smoke/ccip_messaging_test.go
+++ go test integration-tests/smoke/ccip_messaging_test.go
?
There was a problem hiding this comment.
Just a copypasta from the rest of the matrix, would rather stay consistent
There was a problem hiding this comment.
-count=1 is important in E2E tests as it disables Go test caching. Which, in the case of these E2E tests, can lead to false negatives.
0xnogo
reviewed
Nov 13, 2024
0xnogo
approved these changes
Nov 13, 2024
asoliman92
approved these changes
Nov 13, 2024
gheorghestrimtu
approved these changes
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the CCIP messaging test from deployment/ccip to integration-tests/smoke, and transform it into a docker-based test instead of simulated backend.