Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Small fixes #15230

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[chore] Small fixes #15230

merged 2 commits into from
Nov 15, 2024

Conversation

cedric-cordenier
Copy link
Contributor

  • Ensure we start the handler
  • Ensure fetch message ID is < 128

Requires

Supports

@cedric-cordenier
[chore] Small fixes
bd2bf89 
- Ensure we start the handler
- Ensure fetch message ID is < 128
@cedric-cordenier cedric-cordenier requested review from a team as code owners November 13, 2024 19:04
agparadiso
agparadiso previously approved these changes Nov 13, 2024
View reviewed changes
cedric-cordenier
cedric-cordenier commented Nov 13, 2024
View reviewed changes
core/capabilities/compute/compute.go
@@ -294,7 +294,6 @@ func (c *Compute) createFetcher() func(ctx context.Context, req *wasmpb.FetchReq
)

messageID := strings.Join([]string{
req.Metadata.WorkflowId,
req.Metadata.WorkflowExecutionId,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: the workflow execution ID is already unique and the message ID maximum is 128, so we were exceeding it.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

justinkaseman
justinkaseman previously approved these changes Nov 13, 2024
View reviewed changes
bolekk
bolekk previously approved these changes Nov 14, 2024
View reviewed changes
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
@cedric-cordenier
[chore] Small fixes (#15230)
efbb365 
* [chore] Small fixes

- Ensure we start the handler
- Ensure fetch message ID is < 128

* Fix tests
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit 93ee177 Nov 15, 2024
137 of 140 checks passed
@cedric-cordenier cedric-cordenier deleted the misc-fixes branch November 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettec ettec ettec approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@justinkaseman justinkaseman justinkaseman left review comments

@agparadiso agparadiso agparadiso left review comments

@bolekk bolekk bolekk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cedric-cordenier @bolekk @agparadiso @patrickhuie19 @justinkaseman @ettec