Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete merge queue caches on pr merge #15234

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Nov 13, 2024

Changes

  • After PR is merged, also delete caches created during the merge queue.

Motivation

Although I've tried to stop caches from being created on merge queue events, sometimes they're still created. This will also delete caches for refs of the format:

  • gh-readonly-queue/develop/pr-<pr id>-<trunk sha>

Testing

I've only tested locally in bash. I think this will work in CI, but I will have to merge this and see.


RE-3205

@erikburt erikburt self-assigned this Nov 13, 2024
@erikburt erikburt force-pushed the feat/delete-merge-q-caches branch from a8b7cec to 33801b5 Compare November 13, 2024 22:08
@erikburt erikburt marked this pull request as ready for review November 13, 2024 22:14
@erikburt erikburt requested review from a team as code owners November 13, 2024 22:14
@erikburt erikburt enabled auto-merge November 13, 2024 22:19
chainchad
chainchad previously approved these changes Nov 13, 2024
.github/workflows/delete-caches.yml Outdated Show resolved Hide resolved
@erikburt erikburt added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 1d03154 Nov 14, 2024
88 of 90 checks passed
@erikburt erikburt deleted the feat/delete-merge-q-caches branch November 14, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants