Warn user when there's a subtle type diff in ShouldResemble #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ShouldResemble fails confusingly when the visual diff of two items is the same despite DeepEquals being false. See more context in comments in the PR, or at these issues smarty#50 smartystreets/goconvey#665
srabraham
changed the title
|
@srabraham - Thanks! |
mdwhatcott
added a commit
that referenced
this pull request
Apr 3, 2023
> Render doesn't show the types of fields, so something like int(5) will appear the same as int64(5), but they will cause DeepEquals to return false. This message at least makes it clear why there appears to be no diff. A better solution would be to have the diff look for where the two items actually differ, e.g. through something like https://github.com/go-test/deep See PR #51 and Issue #50
|
I've pushed a new release ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ShouldResemble fails confusingly when the visual diff of two items is the same despite DeepEquals being false.
See more context in comments in the PR, or at these issues #50 smartystreets/goconvey#665