Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 10.3.0 #269

Merged
merged 4 commits into from
Dec 13, 2024
Merged

chore: bump version to 10.3.0 #269

merged 4 commits into from
Dec 13, 2024

Conversation

tobitech
Copy link
Contributor

@tobitech tobitech commented Dec 13, 2024

Summary

Prepare for release 10.3.0

Known Issues

  • Previous Selfie Capture sometimes fails to complete (Currently investigating and will address in separate PR). Seems to be a demo app issue.

Test Instructions

N/A.

Screenshot

N/A

@tobitech tobitech self-assigned this Dec 13, 2024
@tobitech tobitech requested a review from a team as a code owner December 13, 2024 16:37
@prfectionist
Copy link

prfectionist bot commented Dec 13, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@prfectionist
Copy link

prfectionist bot commented Dec 13, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SmileID.swift#L159 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L186 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L324 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/SmileID/Classes/SmileID.swift#L403 - Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger Swift against 79782c7

@jumaallan jumaallan merged commit 46c01d5 into main Dec 13, 2024
4 checks passed
@jumaallan jumaallan deleted the release/10.3.0 branch December 13, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants