Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive statements on a line must be separated by ';' #59

Open
Goldtek opened this issue Aug 22, 2024 · 12 comments
Open

Consecutive statements on a line must be separated by ';' #59

Goldtek opened this issue Aug 22, 2024 · 12 comments

Comments

@Goldtek
Copy link

Goldtek commented Aug 22, 2024

Uploading Screenshot 2024-08-22 at 10.18.47.png…

            let response = if isEnroll {
                try await SmileID.api.doSmartSelfieEnrollment(
                    signature: authResponse.signature,
                    timestamp: authResponse.timestamp,
                    selfieImage: smartSelfieImage,
                    livenessImages: smartSelfieLivenessImages,
                    userId: userId,
                    partnerParams: extraPartnerParams,
                    callbackUrl: SmileID.callbackUrl,
                    sandboxResult: nil,
                    allowNewEnroll: allowNewEnroll
                )
            } 

@JNdhlovu @mldangelo @jumaallan @vanshg @ntkzwane

@jumaallan
Copy link
Member

@Goldtek Can you describe the issue better?

@Goldtek
Copy link
Author

Goldtek commented Aug 22, 2024

its complaining about this * let response = if isEnroll {* so i cant even build the project, please is it something that can be quickly looked at @jumaallan

@Goldtek
Copy link
Author

Goldtek commented Aug 26, 2024

Uploading Screenshot 2024-08-26 at 15.25.20.png…
@jumaallan @vanshg @mldangelo @JNdhlovu This has not been looked into yet

if the image is uploaded here did not show, use this wetransfer link to check the image
https://we.tl/t-kRNohvHehP

@Goldtek
Copy link
Author

Goldtek commented Aug 26, 2024

change this on selfieViewModel
 let response = if isEnroll {
                    try await SmileID.api.doSmartSelfieEnrollment(
                        signature: authResponse.signature,
                        timestamp: authResponse.timestamp,
                        selfieImage: smartSelfieImage,
                        livenessImages: smartSelfieLivenessImages,
                        userId: userId,
                        partnerParams: extraPartnerParams,
                        callbackUrl: SmileID.callbackUrl,
                        sandboxResult: nil,
                        allowNewEnroll: allowNewEnroll
                    )
                } else {
                    try await SmileID.api.doSmartSelfieAuthentication(
                        signature: authResponse.signature,
                        timestamp: authResponse.timestamp,
                        userId: userId,
                        selfieImage: smartSelfieImage,
                        livenessImages: smartSelfieLivenessImages,
                        partnerParams: extraPartnerParams,
                        callbackUrl: SmileID.callbackUrl,
                        sandboxResult: nil
                    )
                }
               
                to
               
               
                let response = isEnroll ?
try await SmileID.api.doSmartSelfieEnrollment(
signature: authResponse.signature,
timestamp: authResponse.timestamp,
selfieImage: smartSelfieImage,
livenessImages: smartSelfieLivenessImages,
userId: userId,
partnerParams: extraPartnerParams,
callbackUrl: SmileID.callbackUrl,
sandboxResult: nil,
allowNewEnroll: allowNewEnroll
)
:
try await SmileID.api.doSmartSelfieAuthentication(
signature: authResponse.signature,
timestamp: authResponse.timestamp,
userId: userId,
selfieImage: smartSelfieImage,
livenessImages: smartSelfieLivenessImages,
partnerParams: extraPartnerParams,
callbackUrl: SmileID.callbackUrl,
sandboxResult: nil
)

@Goldtek
Copy link
Author

Goldtek commented Aug 26, 2024

change this on localStorage

 static func isNetworkFailure(
        error: SmileIDError
    ) -> Bool {
        switch error {
        case .httpError:
            true
        default:
            false
        }
    }
   
    to
   
    static func isNetworkFailure(
error: SmileIDError
) -> Bool {
switch error {
case .httpError:
return true
default:
return false
}
}

@Goldtek
Copy link
Author

Goldtek commented Aug 26, 2024

you can thank me

@jumaallan
Copy link
Member

Is this a react native issue @Goldtek ?

@Goldtek
Copy link
Author

Goldtek commented Sep 2, 2024 via email

@Goldtek
Copy link
Author

Goldtek commented Sep 2, 2024 via email

@jumaallan
Copy link
Member

Those files you mentioned exist on our native swift sdk @Goldtek

https://github.com/smileidentity/ios

@Goldtek
Copy link
Author

Goldtek commented Sep 2, 2024 via email

@jumaallan
Copy link
Member

Yes please, also I feel you guys needs ro still look into it

On Mon, 2 Sept 2024, 8:20 am Juma Allan, @.> wrote: Those files you mentioned exist on our native swift sdk @Goldtek https://github.com/Goldtek https://github.com/smileidentity/ios — Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFC5SLGCEUTSYKT2WFD54RDZUQGT3AVCNFSM6AAAAABM5WZSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTHE4TGOJTGY . You are receiving this because you were mentioned.Message ID: @.>

This code runs fine. Can you share more information about where you are using this? Is this being used in a react native repo on your end? what version are you using? that should help us debug the issue better - or you can provide a sample repo that has this issue @Goldtek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants