From ea72d21d59fc7400163d523c1cc4233d626940cd Mon Sep 17 00:00:00 2001 From: Zelda Hessler Date: Mon, 2 Dec 2024 13:25:39 -0600 Subject: [PATCH] respond to PR comments --- aws/rust-runtime/Cargo.lock | 2 +- aws/sdk/integration-tests/s3/tests/signing-it.rs | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/aws/rust-runtime/Cargo.lock b/aws/rust-runtime/Cargo.lock index 2498cd9b05..993dad81f8 100644 --- a/aws/rust-runtime/Cargo.lock +++ b/aws/rust-runtime/Cargo.lock @@ -138,7 +138,7 @@ dependencies = [ [[package]] name = "aws-runtime" -version = "1.4.4" +version = "1.5.0" dependencies = [ "arbitrary", "aws-credential-types", diff --git a/aws/sdk/integration-tests/s3/tests/signing-it.rs b/aws/sdk/integration-tests/s3/tests/signing-it.rs index 79e01afa4d..c1027ec92e 100644 --- a/aws/sdk/integration-tests/s3/tests/signing-it.rs +++ b/aws/sdk/integration-tests/s3/tests/signing-it.rs @@ -72,8 +72,10 @@ async fn disable_payload_signing_works() { assert_eq!("UNSIGNED-PAYLOAD", x_amz_content_sha256); } -// This test ensures that the interceptor's payload signing setting -// takes priority over the runtime plugin for disabling signing. +// This test ensures that the request checksum interceptor payload signing +// override takes priority over the runtime plugin's override. If it didn't, +// then disabling payload signing would cause requests to incorrectly omit +// trailers. #[tokio::test] async fn disable_payload_signing_works_with_checksums() { let (http_client, request) = capture_request(None);