You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Data types for numbers in Oracle are generally described by the catalogue api in format 'data_type': 'NUMBER', 'data_precision': '4'.
The precision is not currently used when creating output table in postgres, bc2pg writes all NUMBER columns to a generic NUMERIC type as defined by sqlalchemy, with no precision (despite what comment says, perhaps this is something that was removed) https://github.com/smnorris/bcdata/blob/main/bcdata/database.py#L156
This is not an issue when working with the data in postgres, but on dumping to other formats the type guessing can be problematic - it would probably be better if the postgres type is better defined.
The text was updated successfully, but these errors were encountered:
Data types for numbers in Oracle are generally described by the catalogue api in format
'data_type': 'NUMBER', 'data_precision': '4'
.The precision is not currently used when creating output table in postgres, bc2pg writes all NUMBER columns to a generic
NUMERIC
type as defined by sqlalchemy, with no precision (despite what comment says, perhaps this is something that was removed)https://github.com/smnorris/bcdata/blob/main/bcdata/database.py#L156
This is not an issue when working with the data in postgres, but on dumping to other formats the type guessing can be problematic - it would probably be better if the postgres type is better defined.
The text was updated successfully, but these errors were encountered: