Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ansible-lint running on PRs from forks? #23

Open
hemberger opened this issue Apr 24, 2023 · 0 comments
Open

Fix ansible-lint running on PRs from forks? #23

hemberger opened this issue Apr 24, 2023 · 0 comments
Labels
question Further information is requested

Comments

@hemberger
Copy link
Member

Currently, ansible-lint in the CI workflow requires secrets from the main repository to run properly. These secrets are not available when the workflow runs on a PR from a fork to prevent exfiltration. If we want to support PRs from forks, we need to provide dummy defaults to the vault variables to avoid errors (see ansible/ansible-lint#3313). I'm a bit uncomfortable with this, because we don't want to accidentally use the dummy values.

Alternatively, we can just require that PR branches be pushed to the main repository instead of a fork. We are unlikely to be receiving external contributions anyway.

@hemberger hemberger added the question Further information is requested label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant