-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print page range on first braille page does not include first print page #49
Comments
There are two separate issues:
Example input: <dtbook>
<book>
<bodymatter>
<level1>
<pagenum page="normal" id="p-2">2</pagenum>
<h1>Hoofdstuk 1</h1>
<p>Eerste alinea.</p>
<pagenum page="normal" id="p-3">3</pagenum>
<p>Tweede alinea.</p>
<p>Derde
<pagenum page="normal" id="p-4">4</pagenum>
alinea.
</p>
</level1>
</bodymatter>
</book>
</dtbook> and expected result:
|
…last See issue snaekobbi/pipeline-mod-dedicon#49 Note that because of this change we break last-except-start!
daisy/pipeline-mod-braille@463796f would fix it if it weren't for this rule in dedicon-default.scss: frontmatter, bodymatter, rearmatter {
/* The following line sets the values used for the top-center page position and the TOC. */
string-set: print-page-from '', print-page-to '', print-page-toc '';
} @dkager: What exactly does this do? |
Off the top of my head this ensures that there are no "left-over" page numbers when changing from frontmatter to bodymatter or from bodymatter to rearmatter. This rule can probably be removed if the scope of a can be limited some other way. Maybe by adding an explicit empty at the start of the bodymatter/rearmatter through XSLT. |
So basically with the empty string you'd like the formatter to behave as if no string was set at all? The specification is currently unclear about what to do in the case of empty strings. And I'm not sure yet what the best would be. Moreover I also haven't figured out how string-set should best behave in combination with flows. It might be that your CSS "hack" wouldn't be needed if string-set would behave differently within flows. What we'll do for now is make the behavior implementation-dependent. I'll add a "treat-string-set-empty-as-absent" parameter to the formatter so you have control. |
OK forget this. It's not that simple because you only want an empty string to mean absent in a backward search, not in a forward search. Now it's starting to smell hackish... |
Maybe a better idea is to have a separate variable |
…last See issue snaekobbi/pipeline-mod-dedicon#49 Note that because of this change we break last-except-start!
In addition, I think accurate print page ranges has (much) higher priority than avoiding some "accidental" print page numbers when the bodymatter begins/ends. The latter can be hacked around, the prior not really. |
…r/rearmatter/colophon. A more reliable solution should be found. re #49
Now that the related SBS issues sbsdev/pipeline-mod-sbs#42 and sbsdev/pipeline-mod-sbs#45 have been fixed, it should be straightforward to fix this issue. I think there are even no changes required in the CSS, just the changes to pipeline-mod-braille which you should be able to cherry-pick from SBS, or alternatively you can wait for these changes to be included in a new version of the Pipeline and then update to that version. For the "left-overs" issue I've created a new Github issue: #54 |
…last See issue snaekobbi/pipeline-mod-dedicon#49 Note that because of this change we break last-except-start!
See test in test_css_formatter.xprocspec.
The text was updated successfully, but these errors were encountered: