Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithread support for transformations #13

Open
Jellyfrog opened this issue Aug 7, 2014 · 2 comments
Open

Multithread support for transformations #13

Jellyfrog opened this issue Aug 7, 2014 · 2 comments
Assignees

Comments

@Jellyfrog
Copy link
Contributor

If you have a database with a high number of transformations rounds it really benefits from multithread support.

KeePass uses multithreading to compute the transformations (the master key is split up to two parts of 128 bits, which is the AES block size). On dual/multi core processors, the computation can be twice as fast as on a single core processor.
http://keepass.info/help/base/security.html

@ppmathis
Copy link
Member

ppmathis commented Aug 8, 2014

Thanks for your suggestion, @Jellyfrog, although I'm not sure if it would make that much sense. I can't implement multithreading in the Node.js method and the native key transformation method is really fast. Do your databases have so many roudns that this would actually matter?

I could implement pthreads for sure within the library, but then it would be no longer compatible to Windows and would require more dependencies than it already does.

@Jellyfrog
Copy link
Contributor Author

It is needed!
Official Keepass client have an option to use the amount of rounds it can generate in 1 second.
With a fast CPU, thats a lot of rounds!

For example my Macbook got 14869504 rounds, that takes 4.2-ish seconds for keepass.io to generate.
And a friend got 50 million rounds on his CPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants