Add some safeties around the charset-detection and transliteration #16376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent some rollbars we get around
iconv()
- this puts a try/catch around theiconv()
call and returns a new translation string for the error which hopefully will be informative for the end-user as they're trying to upload a CSV file.I also added a test with a very gnarly fake WINDOWS-1251 string in it to trigger the new transliteration-failure mode.