Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Patching using Quilt is breaking rendering #19

Open
bzhmaddog opened this issue Feb 7, 2019 · 2 comments
Open

Template Patching using Quilt is breaking rendering #19

bzhmaddog opened this issue Feb 7, 2019 · 2 comments

Comments

@bzhmaddog
Copy link

For the project I am working on I am tweaking the action template and requirements.txt and probably soon the setup.sh too (adding import and some internal classes/lib, logging). To track the changes in the template I am using Quilt so That I can apply all my patches.
The way quilt works is that is needs a folder named 'patches' in the folder where you do changes. it also create a folder named ,pc when you apply patches.
Unfortunately whenever either of theses two folder exists 'snips-template render' will fail with the following error >

[12:02:21.720383] INFO :snips_actions_templates_engine_lib: parsed 1 snippets
thread 'main' panicked at 'not yet implemented', snips-template/snips-actions-templates-engine-lib/src/lib.rs:93:17
note: Run with RUST_BACKTRACE=1 for a backtrace

Failure happens during the renderin of the last snippet making it unusable (no action- python file and no requirements.txt so venv generation fail

@bzhmaddog
Copy link
Author

To reproduce:

  • Install Quilt sudo apt-get install quilt
  • assuming you already have an assistant installed run snips-template render
    No Error happens
  • copy patches folder to /usr/share/snips/snips-actions-templates/python2
  • Run snips-template render > described error occur
  • Go to the folder cd /usr/share/snips/snips-actions-templates/python2
  • Apply patch sudo quilt push
  • Run snips-template render > described error occur
  • Delete Quilt folders sudo rm -rf patches && sudo rm -rf .pc
  • Run snips-template render > Error is gone

@bzhmaddog
Copy link
Author

patches.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant