SNOW-864140: Check build/test instruction for libsnowflakeclient and make correction as needed #737
Conversation
sfc-gh-ext-simba-jy
changed the title
README.rst
Outdated
| Prerequisite | ||
| ^^^^^^^^^^^^^ | ||
| - Ensure you have cmake 2.8 or later version. | ||
| - For Windows, require: one of Visual Studio [VS14, VS15, VS16, VS17] |
There was a problem hiding this comment.
VS14 needs to be removed. After upgrading arrow to 15.x we don't support VS14 build anymore.
There was a problem hiding this comment.
Removed all VS 14 in README.rst
README.rst
Outdated
|
|
||
| Linux and OSX | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| ./scripts/buildDependencies.sh |
There was a problem hiding this comment.
build_dependencies.sh
There was a problem hiding this comment.
Fix typos
| set vs_version=VS14 | ||
| ci\build.bat | ||
| set vs_version=VS17 | ||
| ci\\build_win.bat |
There was a problem hiding this comment.
If possible I would prefer to use similar script for both windows and non-windows. What's the difference between scripts ones and ci ones? which is better for customer to use?
| ---------------------------------------------------------------------- | ||
|
|
||
| Set the Snowflake connection info in ``parameters.json`` and place it in $HOME: | ||
| The list of dependencies |
There was a problem hiding this comment.
I think having one way to build is enough for customer they don't really need to know the options of building third-parties separately.
| @@ -86,7 +123,7 @@ Linux and OSX | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| ./scripts/run_tests.sh | |||
| .ci/scripts/test_linux.sh | |||
There was a problem hiding this comment.
Do you mean ci/test/test.sh ? test_linux.sh is using docker I don't think customer has the access to the docker image.
No description provided.