Review comments

snowflakedb · Aug 11, 2023 · 75640a4 · 75640a4
1 parent b67fb91
commit 75640a4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/net/snowflake/client/core/SFInputBase.java b/src/main/java/net/snowflake/client/core/SFInputBase.java
@@ -16,10 +16,13 @@ Map<String, String> getAdditionalHttpHeaders() {
 
   /**
    * Set additional http headers to apply to the outgoing request. The additional headers cannot be
-   * used to replace or overwrite a header in use by the driver.
+   * used to replace or overwrite a header in use by the driver. These will be applied to the
+   * outgoing request. Primarily used by Snowsight, as described in {@link
+   * HttpUtil#applyAdditionalHeaders(org.apache.http.client.methods.HttpRequestBase, Map)}
    *
    * @param additionalHttpHeaders The new headers to add
    * @return The input object, for chaining
+   * @see HttpUtil#applyAdditionalHeaders(org.apache.http.client.methods.HttpRequestBase, Map)
    */
   @SuppressWarnings("unchecked")
   public T setAdditionalHttpHeaders(Map<String, String> additionalHttpHeaders) {

diff --git a/src/main/java/net/snowflake/client/core/SFLoginInput.java b/src/main/java/net/snowflake/client/core/SFLoginInput.java
@@ -47,7 +47,7 @@ public class SFLoginInput extends SFInputBase<SFLoginInput> {
   private HttpClientSettingsKey httpClientKey;
   private String privateKeyFile;
   private String privateKeyFilePwd;
-  private String inFlightCtx;
+  private String inFlightCtx; // Used for Snowsight account activation
 
   SFLoginInput() {}