Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-848780: Upgrade org.bouncycastle:bc-fips to 1.0.2.4 #1538

Merged
merged 1 commit into from
Oct 25, 2023
Merged

SNOW-848780: Upgrade org.bouncycastle:bc-fips to 1.0.2.4 #1538

merged 1 commit into from
Oct 25, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 20, 2023 •
edited
Loading

Overview

SNOW-848780
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/495

Upgrade org.bouncycastle:bc-fips from 1.0.2.1 to 1.0.2.4

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes Snyk: snowflake-jdbc org.bouncycastle:bc-fips 1.0.2.1 | Snyk ID - SNYK-JAVA-ORGBOUNCYCASTLE-3136316 #1435

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 20, 2023 18:10
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 20, 2023 18:10
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-igarish sfc-gh-igarish merged commit 4453b41 into master Oct 25, 2023
16 checks passed
@sfc-gh-igarish sfc-gh-igarish deleted the SNOW-848780-bc-fips-upgrade branch October 25, 2023 00:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snyk: snowflake-jdbc org.bouncycastle:bc-fips 1.0.2.1 | Snyk ID - SNYK-JAVA-ORGBOUNCYCASTLE-3136316
2 participants
@sfc-gh-ext-simba-jl @sfc-gh-igarish