Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with using Null as DateType #1544

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix issue with using Null as DateType #1544

merged 3 commits into from
Oct 27, 2023

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf commented Oct 26, 2023 •
edited
Loading

Overview

SNOW-898376 Issues on handling NULLs to Date Datatype conversion

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/623

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

When trying to retrieve a Date type result using the syntax "Select NULL as Date_Colum from Table", the NULL was being interpreted as a varchar by the converters. I've added some logic for how to convert this type of NULL to a null date in the VarCharConverter.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner October 26, 2023 09:14
@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-ext-simba-jf
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf merged commit 9fbaa7a into master Oct 27, 2023
14 checks passed
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf deleted the SNOW-898376-Null-To-Date-Conversion-Fix branch October 27, 2023 06:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jf @sfc-gh-igarish