Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-919389: move the dependencies to parent pom file #1546

Merged
merged 11 commits into from
Dec 5, 2023
Merged

SNOW-919389: move the dependencies to parent pom file #1546

merged 11 commits into from
Dec 5, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 27, 2023 •
edited
Loading

Overview

SNOW-919389
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/660

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

<dependencyManagement> and <dependencies> are moved to parent-pom.xml as a parent pom.
Both pom.xml and FIPS/pom.xml will refer to the same parent-pom.xml so all the dependencies versions will be the same except bouncycastle.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 27, 2023 17:09
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 27, 2023 17:09
sfc-gh-igarish
sfc-gh-igarish reviewed Nov 15, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
sfc-gh-igarish
sfc-gh-igarish approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure both fips and non-fips able to build before the merge.

sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Nov 16, 2023
View reviewed changes
base_pom.xml Outdated Show resolved Hide resolved
base_pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Nov 16, 2023
View reviewed changes
base_pom.xml Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Nov 16, 2023
View reviewed changes
FIPS/pom.xml Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title SNOW-919389: move the dependencies to base_pom.xml SNOW-919389: move the dependencies to parent pom file Nov 23, 2023
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl mentioned this pull request Nov 24, 2023
Closed
8 tasks
@sonarqubemergegate SonarQubeMergeGate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 1bf4e1f into master Dec 5, 2023
28 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-919389-base-pom branch December 5, 2023 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus left review comments

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-ext-simba-jl @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pfus