Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1799642: Add array bind supported log for prepared statements #1960

Merged
merged 1 commit into from
Nov 13, 2024
Merged

SNOW-1799642: Add array bind supported log for prepared statements #1960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/net/snowflake/client/jdbc/SnowflakePreparedStatementV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,19 @@ class SnowflakePreparedStatementV1 extends SnowflakeStatementV1
implements PreparedStatement, SnowflakePreparedStatement {
private static final SFLogger logger =
SFLoggerFactory.getLogger(SnowflakePreparedStatementV1.class);

/** Error code returned when describing a statement that is binding table name */
private static final Integer ERROR_CODE_TABLE_BIND_VARIABLE_NOT_SET = 2128;

/** Error code when preparing statement with binding object names */
private static final Integer ERROR_CODE_OBJECT_BIND_NOT_SET = 2129;

/** Error code returned when describing a ddl command */
private static final Integer ERROR_CODE_STATEMENT_CANNOT_BE_PREPARED = 7;

/** snow-44393 Workaround for compiler cannot prepare to_timestamp(?, 3) */
private static final Integer ERROR_CODE_FORMAT_ARGUMENT_NOT_STRING = 1026;

/** A hash set that contains the error code that will not lead to exception in describe mode */
private static final Set<Integer> errorCodesIgnoredInDescribeMode =
new HashSet<>(
Expand All @@ -88,10 +93,12 @@ class SnowflakePreparedStatementV1 extends SnowflakeStatementV1
* <p>Currently, bind name is just value index
*/
private Map<String, ParameterBindingDTO> parameterBindings = new HashMap<>();

/** map of bind values for batch query executions */
private Map<String, ParameterBindingDTO> batchParameterBindings = new HashMap<>();

private Map<String, Boolean> wasPrevValueNull = new HashMap<>();

/** Counter for batch size if we are executing a statement with array bind supported */
private int batchSize = 0;

Expand Down Expand Up @@ -133,6 +140,12 @@ private void describeSqlIfNotTried() throws SQLException {
if (!alreadyDescribed) {
try {
this.preparedStatementMetaData = sfBaseStatement.describe(sql);
if (preparedStatementMetaData != null
&& !preparedStatementMetaData.isArrayBindSupported()) {
logger.debug(
sfc-gh-dprzybysz marked this conversation as resolved.
Show resolved Hide resolved
"Array bind is not supported - each batch entry will be executed as a single request for query: {}",
sql);
}
} catch (SFException e) {
throw new SnowflakeSQLLoggedException(connection.getSFBaseSession(), e);
} catch (SnowflakeSQLException e) {
Expand Down
Loading