Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the built-in regexp_replace function in java/scala #49

Conversation

jbergeroncoveo
Copy link

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-897574: Add built-in function regexp_replace#46

  2. Fill out the following pre-review checklist:

    • [:white_check_mark: : ] I am adding a new automated test(s) to verify correctness of my new code
    • [:x: ] I am adding new logging messages
    • [:x: ] I am adding a new telemetry message
    • [:x: ] I am adding new credentials
    • [:x: ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Added the builtin function regexp_replace in and scala and java code base.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@jbergeroncoveo jbergeroncoveo changed the title Added the regexp_replace function and added tests. Add the built-in regexp_replace function in java/scala Aug 29, 2023
@sfc-gh-jfreeberg
Copy link
Collaborator

Closes #46

@sfc-gh-bli
Copy link
Collaborator

Thank you for your contribution. I did some small changes in your PR and filed a new PR here. #52

@sfc-gh-bli sfc-gh-bli closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-897574: Add built-in function regexp_replace
3 participants