Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 802269 add locate, randn and ntile functions #146

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Snow 802269 add locate, randn and ntile functions #146

merged 6 commits into from
Aug 21, 2024
+343 −0

Conversation

sfc-gh-gmahadevan
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #802269

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Add locate, randn and ntile functions for scala and java which takes column name as both ColumnType and StringType

API Description
functions.locate Locate the position of the first occurrence of substr in a string column
functions.ntile NTILE
funstions.randn Generate Random number

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-bli
sfc-gh-bli approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-gmahadevan sfc-gh-gmahadevan merged commit 172caca into main Aug 21, 2024
18 checks passed
@sfc-gh-gmahadevan sfc-gh-gmahadevan deleted the snow-802269-func4-gm branch August 21, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

@sfc-gh-mrojas sfc-gh-mrojas Awaiting requested review from sfc-gh-mrojas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-gmahadevan @sfc-gh-bli