-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors guide for modifying the data file #132
Comments
Agree, we need an initiative to write a contributors guide for the data file... |
More than just naming conventions - also rules like:
|
Also useful:
@alexanderdean - happy to work on something like this too. Can a pull request be made for GH wikis? |
We also assembled more ESP domain names and would like to see them mentioned in the referer.yml file. Is there a process by now? |
The process is not yet finished, but we are working on it. Please open a PR and we will get a new versions of the referer.yml database published. The unfinished work is around making the Java client read an external file, and updating the Snowplow enrichment to support that external file. |
Well, i don't have a proper referer.yml file but a list of 3600+ ESP domain names. Would that be of any interest to you? |
Wow - that does sound interesting! |
For new additions to the referrer YAML, it would be helpful if there were some guidelines on how to name / group sites.
Based on what I see in the YAML now, I don't even agree with past contributions I've made. E.g.:
Naver Mail
should just beNaver
... just like howGoogle
is representedemail
makes sense because we can see traffic arriving through Cheetah Mail or Responsys servers but we wouldn't call them an email provider.Thoughts?
The text was updated successfully, but these errors were encountered: