Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-conduit removes '<' symbols from strings in '<script>' tags #139

Open
emhoracek opened this issue Oct 17, 2018 · 2 comments
Open

html-conduit removes '<' symbols from strings in '<script>' tags #139

emhoracek opened this issue Oct 17, 2018 · 2 comments

Comments

@emhoracek
Copy link
Contributor

Ran into problems with the custom javascript components in my app after upgrading our template library to the latest version.

I tried this test:

  it "should not remove '<' symbols in script strings" $
    let (X.Document _ (X.Element _ _ nodes) _) =
      H.parseLT ("<script>console.log(\"<custom-component />\")</script>") in
    nodes `shouldBe` [X.NodeContent "console.log(\"<custom-component />\")"]

It fails with:

1) HTML parsing should not remove '<' symbols in script strings
    expected: [NodeContent "console.log(\"<custom-component />\")"]
    but got: [NodeContent "console.log(\"custom-component />\")"]
@snoyberg
Copy link
Owner

You say that upgrading to the latest version has this problem. Do earlier version not have this problem?

@emhoracek
Copy link
Contributor Author

@snoyberg Earlier versions did not have this problem -- upgrading our Stackage resolver from lts-8.15 to lts-12.11 is what caused it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants