Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. UI Changes For Consistency with HN #32

Open
8 of 10 tasks
johnwarden opened this issue Sep 26, 2022 · 2 comments
Open
8 of 10 tasks

Misc. UI Changes For Consistency with HN #32

johnwarden opened this issue Sep 26, 2022 · 2 comments

Comments

@johnwarden
Copy link
Contributor

johnwarden commented Sep 26, 2022

  • Highlight "hntop" in white on the hntop page (the original HN does the same for all pages but the front page)
  • Show "Discuss" instead of "0 Comments" when there are no comments
  • "N minutes ago" should link to the story page
  • Username should link to user page
  • Show domain after story title
  • Mobile/smalls viewports:
    • slightly larger right margin (just a few pixels it appears to me)
    • wrap after a |
  • Do we want the same margins around the page content (grey background) as the original
  • when you hover over a relative time (e.g. 2 days ago) on HN, it shows the iso timestamp.
  • usernames for new users appear in green.
@fdietze
Copy link
Contributor

fdietze commented Oct 29, 2022

@johnwarden what exactly do you mean with:

  • "slightly larger right margin (just a few pixels it appears to me)"
  • "wrap after a |"

@johnwarden johnwarden added this to the Essential for Launch milestone Nov 16, 2022
@fdietze
Copy link
Contributor

fdietze commented Feb 4, 2023

  • I don't think we need margins to be exactly the same as on HN. We have our own page layout which just looks similar.
  • New users appearing in green are not essential for launching on HN

@fdietze fdietze removed this from the Essential for Launch milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants