Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question autosuggest improvements #68

Open
zang0 opened this issue Sep 22, 2016 · 5 comments
Open

question autosuggest improvements #68

zang0 opened this issue Sep 22, 2016 · 5 comments
Assignees

Comments

@zang0
Copy link
Contributor

zang0 commented Sep 22, 2016

_1 guarantee apriori allocated memory is not violated w/ logging of dropped questions
_2 king county wa > should not match all the NY results
_3 curious terms that yield no results

male, female, median, earnings, ...

are these vars never added for some reason? or stop worded?

_4 98117

note: only 3 questions, looks like lots are missing, see the grad rates, earnings permutations, etc.

@zang0 zang0 added this to the V4 milestone Sep 22, 2016
@aaasen
Copy link
Contributor

aaasen commented Sep 23, 2016

Fixed these issues, demo here: https://opendatanetwork-staging-pr-599.herokuapp.com/

@zang0
Copy link
Contributor Author

zang0 commented Sep 26, 2016

re: _2 -> curious why "king county wa" is matching "king county va" and "king county tx"

_5 - jobs > matches on population count, term mapping problem?
_5.1 - multinoma > same thing

_6 - obesity > matches on only california obesity rates, should get a bunch of matches

_7 - default georegion matches for things like "graduation rates" - i think we should go w/ states/metros/counties/cities as results and not include us, divisions as they're typically odd and the maps are all buggered up on landing

_8 - queries like kalamazoo, questions should be diversified across variables like in prod

_9 - 'crime' returns no questions, but 'crime seattle' does

@zang0
Copy link
Contributor Author

zang0 commented Sep 30, 2016

I added a super simple first pass script to generate a basic ontology w/ synonyms and misspellings for cities. The current file is in: https://github.com/socrata/odn-backend/blob/staging/scripts/ontology/place-synonyms.json in staging. Have a look and see if you can incorporate it into the autosuggest. I can improve the ontology over time once its wired in.

@zang0
Copy link
Contributor Author

zang0 commented Oct 13, 2016

Agreed to eliminate the clear misses, e.g. jobs > population returns and then have a look.

aaasen added a commit that referenced this issue Oct 13, 2016
@aaasen
Copy link
Contributor

aaasen commented Oct 13, 2016

One problem with this is that we no longer return questions for a single entity e.g. "seattle".

Also, for the synonyms, check https://github.com/socrata/odn-backend/blob/staging/data/aliases.json

@zang0 zang0 removed this from the V4 milestone Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants