Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods should (maybe) not return Observation* and Action* #35

Open
sofian opened this issue Jul 12, 2012 · 1 comment
Open

Methods should (maybe) not return Observation* and Action* #35

sofian opened this issue Jul 12, 2012 · 1 comment
Labels

Comments

@sofian
Copy link
Owner

sofian commented Jul 12, 2012

The reason being that in no case are these pointers generated on the spot. They are thus confusing. This may also result in memory consuming implementations, for instance when one has to "save" those pointers for later use.

Instead, Agent should just have an Action* and Environment an Observation*.

@sofian
Copy link
Owner Author

sofian commented Jul 12, 2012

There is an issue though, which is that by using a member class pointer, we need to dynamically allocate the Action or Observation object, which is a bit tricky on AVR. However, since we already do it for NeuralNetwork + we have a StaticAllocator mechanism, then, why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant