[tests] Change expected bitrate in offline processing test #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
commented
Oct 22, 2024
| @@ -123,7 +123,7 @@ pub fn offline_processing() -> Result<()> { | |||
| if !(1.9..=2.1).contains(&duration) { | |||
| return Err(anyhow!("Invalid duration: {}", duration)); | |||
| } | |||
| if !(930_000..=1_008_200).contains(&bit_rate) { | |||
| if !(938_200..=1_008_200).contains(&bit_rate) { | |||
There was a problem hiding this comment.
For reference, the maximum expected bitrate was changed in this PR #833
|
please adjust it to sth reasonable, I assume you increased it to 1_008_200 because the resulting value was around that. Is there any reason that the result might be around |
noituri
force-pushed
the
@noituri/offline-processing-bitrate
branch
2 times, most recently
from
34744c1 to
992b099
Compare
noituri
force-pushed
the
@noituri/offline-processing-bitrate
branch
from
992b099 to
3ecdbc0
Compare
wkozyra95
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.