Add ChessPieceTests to Explicitly Test equals and hashCode

[frozenfrank]

No description provided.

[19mdavenport]

Were you thinking of making a new file for this? If so, what do you think about moving the "Piece moves on all pieces" test into that file? It feels a little awkward in ChessBoardTests but i didn't have a better place to put it at the time

[frozenfrank]

Were you thinking of making a new file for this? If so, what do you think about moving the "Piece moves on all pieces" test into that file? It feels a little awkward in ChessBoardTests but i didn't have a better place to put it at the time

@19mdavenport That's a great idea! I'll do that too.

[frozenfrank]

Were you thinking of making a new file for this? If so, what do you think about moving the "Piece moves on all pieces" test into that file? It feels a little awkward in ChessBoardTests but i didn't have a better place to put it at the time

@19mdavenport After looking at it more carefully, there is a technical snag to completing this refactor: the test currently relies on a working ChessBoard.resetBoard() method.

chess/shared/src/test/java/passoff/chess/ChessBoardTests.java

Lines 43 to 57 in 4ddf543

	@Test
	@DisplayName("Piece Move on All Pieces")
	public void pieceMoveAllPieces() {
	var board = new ChessBoard();
	board.resetBoard();
	for(int i = 1; i <= 8; i++) {
	for(int j = 1; j <= 8; j++) {
	ChessPosition position = new ChessPosition(i, j);
	ChessPiece piece = board.getPiece(position);
	if(piece != null) {
	Assertions.assertDoesNotThrow(() -> piece.pieceMoves(board, position));
	}
	}
	}
	}

We could leave the method there, I don't think that would be a problem.

What do you think about calling pieceMoves() a board with every single piece placed in every single position? 886 = 384 total invocations... I think that's reasonable.

[frozenfrank]

@19mdavenport Update: We doubled the total tests and completed this request in commit 41db8c8.