Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatsMonadAsyncError shouldn't use eval for blocking #1998

Closed
kciesielski opened this issue Nov 9, 2023 · 1 comment
Closed

CatsMonadAsyncError shouldn't use eval for blocking #1998

kciesielski opened this issue Nov 9, 2023 · 1 comment

Comments

@kciesielski
Copy link
Member

Reported here: https://softwaremill.community/t/sttp-monad-monaderror-blocking-for-cats-effect/314/3

CatsMonadAsyncError uses the default implementation from MonadError:

def blocking[T](t: => T): F[T] = eval(t)

and eval is implemented as follows:

override def eval[T](t: => T): F[T] = F.delay(t)

So, delay is used for blocking actions.

@adamw
Copy link
Member

adamw commented Nov 9, 2023

Fixed here: #1993 :)

@adamw adamw closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants